From 117eaddaa0cc3c09ddaf07d96ddf1784d2426503 Mon Sep 17 00:00:00 2001
From: David Keane <david.keane.1974@gmail.com>
Date: Mon, 8 Jun 2026 14:55:04 +0100
Subject: [PATCH] =?UTF-8?q?chore:=20v0.1.5=20=E2=80=94=20wp.org=20reviewer?=
 =?UTF-8?q?-feedback=20fix?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reviewer flagged inc/about.php line 19 — an inline <style> block —
asking us to use wp_enqueue_style instead. Per their hint that the
team may not list every instance of an issue, fixed the entire CSS
inline-styling pattern across the plugin:

- inc/about.php: <style> block (lines 19-59) → moved to buddy.css
- inc/about.php: <span style="color:#646970; font-weight:400;">
  → .buddy-about-intro__version class
- inc/about.php: <p style="margin-bottom:0;"> → .buddy-about-intro__cta
- inc/settings.php: <form style="..."> → .buddy-settings-form class
- inc/settings.php: <h2 style="margin-top:0;"> → scoped under form class
- inc/admin-page.php: <p style="max-width:720px;">
  → .buddy-admin-description utility class

The only remaining inline style is in inc/dashboard-widget.php at the
stat-bar width — that is a runtime-computed %d value, legitimately
inline.

The buddy.css file was already enqueued on the About / Settings /
Admin / Dashboard pages via the existing buddy_enqueue_admin_assets
function, so no new enqueue logic was needed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 assets/css/buddy.css | 81 ++++++++++++++++++++++++++++++++++++++++++++
 buddy.php            |  4 +--
 inc/about.php        | 46 ++-----------------------
 inc/admin-page.php   |  2 +-
 inc/settings.php     |  4 +--
 readme.txt           |  9 ++++-
 6 files changed, 96 insertions(+), 50 deletions(-)

diff --git a/assets/css/buddy.css b/assets/css/buddy.css
index 763d6e5..cb77617 100644
--- a/assets/css/buddy.css
+++ b/assets/css/buddy.css
@@ -168,3 +168,84 @@
     font-size: 13px;
     border-radius: 0 4px 4px 0;
 }
+
+/* ── About page ──────────────────────────────────────────────────── */
+
+.buddy-about-intro {
+    display: flex;
+    gap: 24px;
+    align-items: center;
+    flex-wrap: wrap;
+    margin: 16px 0 28px;
+    padding: 18px;
+    background: #fff;
+    border: 1px solid #ccd0d4;
+    border-radius: 4px;
+}
+.buddy-about-intro__sprite {
+    flex: 0 0 160px;
+    display: flex;
+    justify-content: center;
+}
+.buddy-about-intro__body {
+    flex: 1 1 320px;
+    min-width: 0;
+}
+.buddy-about-intro__body h2 { margin-top: 0; }
+.buddy-about-intro__version {
+    color: #646970;
+    font-weight: 400;
+}
+.buddy-about-intro__cta {
+    margin-bottom: 0;
+}
+
+.buddy-about-card {
+    background: #fff;
+    border: 1px solid #ccd0d4;
+    border-radius: 4px;
+    padding: 20px 24px;
+    margin: 0 0 22px;
+    max-width: 720px;
+}
+.buddy-about-card h2 { margin: 0 0 10px; font-size: 16px; }
+.buddy-about-card p:last-child { margin-bottom: 0; }
+.buddy-about-card ul { margin: 8px 0 0 18px; list-style: disc; }
+.buddy-about-card ul li { margin-bottom: 4px; }
+.buddy-about-card--versions ul { list-style: none; margin-left: 0; }
+.buddy-about-card--versions li { margin-bottom: 12px; }
+.buddy-about-card--versions .ver { font-weight: 600; color: #2271b1; }
+.buddy-about-card--versions .latest {
+    display: inline-block;
+    margin-left: 6px;
+    padding: 1px 7px;
+    background: #00a32a;
+    color: #fff;
+    border-radius: 9px;
+    font-size: 11px;
+    font-weight: 600;
+}
+.buddy-about-changelog-link {
+    display: inline-block;
+    margin-top: 6px;
+    font-size: 13px;
+    color: #646970;
+}
+
+/* ── Settings page form + admin-page description ─────────────────── */
+
+.buddy-admin-description {
+    max-width: 720px;
+}
+
+.buddy-settings-form {
+    max-width: 720px;
+    background: #fff;
+    padding: 18px 22px;
+    border: 1px solid #ccd0d4;
+    border-radius: 4px;
+    margin-top: 16px;
+}
+.buddy-settings-form h2 {
+    margin-top: 0;
+}
diff --git a/buddy.php b/buddy.php
index c8976c0..4890606 100644
--- a/buddy.php
+++ b/buddy.php
@@ -5,7 +5,7 @@
  * Plugin Name: RangerHQ Buddy
  * Plugin URI:  https://davidtkeane.com/rangerhq-buddy
  * Description: Adopt a small companion that lives in your WordPress dashboard. Its mood reflects your site's health — published posts feed it, outdated plugins make it sick, clearing spam makes it happy. Gamifies WordPress maintenance with a bit of charm.
- * Version:     0.1.4
+ * Version:     0.1.5
  * Requires at least: 5.0
  * Requires PHP: 7.4
  * Author:      David Keane
@@ -20,7 +20,7 @@
 if ( ! defined( 'ABSPATH' ) ) { exit; }
 
 // Plugin coordinates.
-if ( ! defined( 'BUDDY_VERSION' ) )  { define( 'BUDDY_VERSION',  '0.1.4' ); }
+if ( ! defined( 'BUDDY_VERSION' ) )  { define( 'BUDDY_VERSION',  '0.1.5' ); }
 if ( ! defined( 'BUDDY_FILE' ) )     { define( 'BUDDY_FILE',     __FILE__ ); }
 if ( ! defined( 'BUDDY_PATH' ) )     { define( 'BUDDY_PATH',     plugin_dir_path( __FILE__ ) ); }
 if ( ! defined( 'BUDDY_URL' ) )      { define( 'BUDDY_URL',      plugin_dir_url( __FILE__ ) ); }
diff --git a/inc/about.php b/inc/about.php
index 7038c41..463fa9a 100644
--- a/inc/about.php
+++ b/inc/about.php
@@ -16,48 +16,6 @@ function buddy_render_about_page() {
         wp_die( esc_html__( 'You do not have permission to view this page.', 'rangerhq-buddy' ) );
     }
     ?>
-    <style>
-        .buddy-about-intro {
-            display: flex;
-            gap: 24px;
-            align-items: center;
-            flex-wrap: wrap;
-            margin: 16px 0 28px;
-            padding: 18px;
-            background: #fff;
-            border: 1px solid #ccd0d4;
-            border-radius: 4px;
-        }
-        .buddy-about-intro__sprite {
-            flex: 0 0 160px;
-            display: flex;
-            justify-content: center;
-        }
-        .buddy-about-intro__body {
-            flex: 1 1 320px;
-            min-width: 0;
-        }
-        .buddy-about-intro__body h2 { margin-top: 0; }
-
-        .buddy-about-card {
-            background: #fff;
-            border: 1px solid #ccd0d4;
-            border-radius: 4px;
-            padding: 20px 24px;
-            margin: 0 0 22px;
-            max-width: 720px;
-        }
-        .buddy-about-card h2 { margin: 0 0 10px; font-size: 16px; }
-        .buddy-about-card p:last-child { margin-bottom: 0; }
-        .buddy-about-card ul { margin: 8px 0 0 18px; list-style: disc; }
-        .buddy-about-card ul li { margin-bottom: 4px; }
-        .buddy-about-card--versions ul { list-style: none; margin-left: 0; }
-        .buddy-about-card--versions li { margin-bottom: 12px; }
-        .buddy-about-card--versions .ver { font-weight: 600; color: #2271b1; }
-        .buddy-about-card--versions .latest { display:inline-block; margin-left:6px; padding:1px 7px; background:#00a32a; color:#fff; border-radius:9px; font-size:11px; font-weight:600; }
-        .buddy-about-changelog-link { display: inline-block; margin-top: 6px; font-size: 13px; color: #646970; }
-    </style>
-
     <div class="wrap">
         <h1 class="wp-heading-inline"><?php esc_html_e( 'About', 'rangerhq-buddy' ); ?></h1>
         <span class="page-title-action">v<?php echo esc_html( BUDDY_VERSION ); ?></span>
@@ -70,9 +28,9 @@ function buddy_render_about_page() {
                 <?php buddy_render_sprite( 'default', 'happy', 'lg' ); ?>
             </div>
             <div class="buddy-about-intro__body">
-                <h2>Buddy <span style="color:#646970; font-weight:400;">v<?php echo esc_html( BUDDY_VERSION ); ?></span></h2>
+                <h2>Buddy <span class="buddy-about-intro__version">v<?php echo esc_html( BUDDY_VERSION ); ?></span></h2>
                 <p>A friendly little companion that lives in your WordPress dashboard. The idea: keep Buddy's stats up, eventually Buddy's mood will reflect how well you're taking care of your site itself. Gamifies WordPress maintenance with a bit of charm.</p>
-                <p style="margin-bottom:0;">
+                <p class="buddy-about-intro__cta">
                     <a href="<?php echo esc_url( admin_url( 'admin.php?page=buddy' ) ); ?>" class="button button-primary"><?php esc_html_e( 'Go to My Buddy →', 'rangerhq-buddy' ); ?></a>
                 </p>
             </div>
diff --git a/inc/admin-page.php b/inc/admin-page.php
index 56410ac..5ac9a0f 100644
--- a/inc/admin-page.php
+++ b/inc/admin-page.php
@@ -29,7 +29,7 @@ function buddy_render_main_page() {
         <span class="page-title-action">v<?php echo esc_html( BUDDY_VERSION ); ?></span>
         <hr class="wp-header-end">
 
-        <p class="description" style="max-width: 720px;">
+        <p class="description buddy-admin-description">
             <?php esc_html_e( 'Your dashboard pet. Keep its stats up — eventually they will reflect how well you take care of your WordPress site.', 'rangerhq-buddy' ); ?>
             <a href="<?php echo esc_url( admin_url( 'admin.php?page=buddy-about' ) ); ?>"><?php esc_html_e( 'Read more on the About page →', 'rangerhq-buddy' ); ?></a>
         </p>
diff --git a/inc/settings.php b/inc/settings.php
index ef0a04f..af17c1a 100644
--- a/inc/settings.php
+++ b/inc/settings.php
@@ -47,9 +47,9 @@ function buddy_render_settings_page() {
     <div class="wrap">
         <h1><?php esc_html_e( 'Buddy Settings', 'rangerhq-buddy' ); ?></h1>
 
-        <form method="post" style="max-width: 720px; background:#fff; padding:18px 22px; border:1px solid #ccd0d4; border-radius:4px; margin-top: 16px;">
+        <form method="post" class="buddy-settings-form">
             <?php wp_nonce_field( 'buddy_rename', 'buddy_rename_nonce' ); ?>
-            <h2 style="margin-top:0;"><?php esc_html_e( 'Name', 'rangerhq-buddy' ); ?></h2>
+            <h2><?php esc_html_e( 'Name', 'rangerhq-buddy' ); ?></h2>
             <p>
                 <label for="buddy_name"><?php esc_html_e( 'What is your Buddy called?', 'rangerhq-buddy' ); ?></label><br>
                 <input type="text"
diff --git a/readme.txt b/readme.txt
index d1e8ebc..3d77f03 100644
--- a/readme.txt
+++ b/readme.txt
@@ -4,7 +4,7 @@ Tags: dashboard, pet, gamification, virtual-pet, fun
 Requires at least: 5.0
 Tested up to: 7.0
 Requires PHP: 7.4
-Stable tag: 0.1.4
+Stable tag: 0.1.5
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
 
@@ -83,6 +83,10 @@ Yes. The plugin is GPL v2 or later and the full source is published on Gitea at
 
 == Changelog ==
 
+= 0.1.5 =
+* Moved the About page inline `<style>` block into the enqueued `buddy.css` stylesheet per WordPress.org reviewer feedback.
+* Replaced inline `style="..."` attributes on the Settings form, Settings name heading, and main admin page description with proper CSS classes. The only remaining inline style is the dynamic stat-bar `width:%d%%` value in the Dashboard widget, which is runtime data.
+
 = 0.1.4 =
 * Renamed to RangerHQ Buddy as part of the RangerHQ plugin family naming convention.
 * Updated Plugin URI and Author URI to davidtkeane.com.
@@ -105,5 +109,8 @@ Yes. The plugin is GPL v2 or later and the full source is published on Gitea at
 
 == Upgrade Notice ==
 
+= 0.1.5 =
+WordPress.org reviewer-feedback fix — all CSS now properly enqueued via wp_enqueue_style instead of inline. No user-visible behaviour changes.
+
 = 0.1.4 =
 Plugin renamed to RangerHQ Buddy and prepared for the WordPress.org Plugin Directory. No user-visible behaviour changes; existing Buddy state preserved.