chore: v0.1.5 — wp.org reviewer-feedback fix
Reviewer flagged inc/about.php line 19 — an inline <style> block — asking us to use wp_enqueue_style instead. Per their hint that the team may not list every instance of an issue, fixed the entire CSS inline-styling pattern across the plugin: - inc/about.php: <style> block (lines 19-59) → moved to buddy.css - inc/about.php: <span style="color:#646970; font-weight:400;"> → .buddy-about-intro__version class - inc/about.php: <p style="margin-bottom:0;"> → .buddy-about-intro__cta - inc/settings.php: <form style="..."> → .buddy-settings-form class - inc/settings.php: <h2 style="margin-top:0;"> → scoped under form class - inc/admin-page.php: <p style="max-width:720px;"> → .buddy-admin-description utility class The only remaining inline style is in inc/dashboard-widget.php at the stat-bar width — that is a runtime-computed %d value, legitimately inline. The buddy.css file was already enqueued on the About / Settings / Admin / Dashboard pages via the existing buddy_enqueue_admin_assets function, so no new enqueue logic was needed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -168,3 +168,84 @@
|
||||
font-size: 13px;
|
||||
border-radius: 0 4px 4px 0;
|
||||
}
|
||||
|
||||
/* ── About page ──────────────────────────────────────────────────── */
|
||||
|
||||
.buddy-about-intro {
|
||||
display: flex;
|
||||
gap: 24px;
|
||||
align-items: center;
|
||||
flex-wrap: wrap;
|
||||
margin: 16px 0 28px;
|
||||
padding: 18px;
|
||||
background: #fff;
|
||||
border: 1px solid #ccd0d4;
|
||||
border-radius: 4px;
|
||||
}
|
||||
.buddy-about-intro__sprite {
|
||||
flex: 0 0 160px;
|
||||
display: flex;
|
||||
justify-content: center;
|
||||
}
|
||||
.buddy-about-intro__body {
|
||||
flex: 1 1 320px;
|
||||
min-width: 0;
|
||||
}
|
||||
.buddy-about-intro__body h2 { margin-top: 0; }
|
||||
.buddy-about-intro__version {
|
||||
color: #646970;
|
||||
font-weight: 400;
|
||||
}
|
||||
.buddy-about-intro__cta {
|
||||
margin-bottom: 0;
|
||||
}
|
||||
|
||||
.buddy-about-card {
|
||||
background: #fff;
|
||||
border: 1px solid #ccd0d4;
|
||||
border-radius: 4px;
|
||||
padding: 20px 24px;
|
||||
margin: 0 0 22px;
|
||||
max-width: 720px;
|
||||
}
|
||||
.buddy-about-card h2 { margin: 0 0 10px; font-size: 16px; }
|
||||
.buddy-about-card p:last-child { margin-bottom: 0; }
|
||||
.buddy-about-card ul { margin: 8px 0 0 18px; list-style: disc; }
|
||||
.buddy-about-card ul li { margin-bottom: 4px; }
|
||||
.buddy-about-card--versions ul { list-style: none; margin-left: 0; }
|
||||
.buddy-about-card--versions li { margin-bottom: 12px; }
|
||||
.buddy-about-card--versions .ver { font-weight: 600; color: #2271b1; }
|
||||
.buddy-about-card--versions .latest {
|
||||
display: inline-block;
|
||||
margin-left: 6px;
|
||||
padding: 1px 7px;
|
||||
background: #00a32a;
|
||||
color: #fff;
|
||||
border-radius: 9px;
|
||||
font-size: 11px;
|
||||
font-weight: 600;
|
||||
}
|
||||
.buddy-about-changelog-link {
|
||||
display: inline-block;
|
||||
margin-top: 6px;
|
||||
font-size: 13px;
|
||||
color: #646970;
|
||||
}
|
||||
|
||||
/* ── Settings page form + admin-page description ─────────────────── */
|
||||
|
||||
.buddy-admin-description {
|
||||
max-width: 720px;
|
||||
}
|
||||
|
||||
.buddy-settings-form {
|
||||
max-width: 720px;
|
||||
background: #fff;
|
||||
padding: 18px 22px;
|
||||
border: 1px solid #ccd0d4;
|
||||
border-radius: 4px;
|
||||
margin-top: 16px;
|
||||
}
|
||||
.buddy-settings-form h2 {
|
||||
margin-top: 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user