chore: v0.1.5 — wp.org reviewer-feedback fix
Reviewer flagged inc/about.php line 19 — an inline <style> block — asking us to use wp_enqueue_style instead. Per their hint that the team may not list every instance of an issue, fixed the entire CSS inline-styling pattern across the plugin: - inc/about.php: <style> block (lines 19-59) → moved to buddy.css - inc/about.php: <span style="color:#646970; font-weight:400;"> → .buddy-about-intro__version class - inc/about.php: <p style="margin-bottom:0;"> → .buddy-about-intro__cta - inc/settings.php: <form style="..."> → .buddy-settings-form class - inc/settings.php: <h2 style="margin-top:0;"> → scoped under form class - inc/admin-page.php: <p style="max-width:720px;"> → .buddy-admin-description utility class The only remaining inline style is in inc/dashboard-widget.php at the stat-bar width — that is a runtime-computed %d value, legitimately inline. The buddy.css file was already enqueued on the About / Settings / Admin / Dashboard pages via the existing buddy_enqueue_admin_assets function, so no new enqueue logic was needed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
+2
-2
@@ -47,9 +47,9 @@ function buddy_render_settings_page() {
|
||||
<div class="wrap">
|
||||
<h1><?php esc_html_e( 'Buddy Settings', 'rangerhq-buddy' ); ?></h1>
|
||||
|
||||
<form method="post" style="max-width: 720px; background:#fff; padding:18px 22px; border:1px solid #ccd0d4; border-radius:4px; margin-top: 16px;">
|
||||
<form method="post" class="buddy-settings-form">
|
||||
<?php wp_nonce_field( 'buddy_rename', 'buddy_rename_nonce' ); ?>
|
||||
<h2 style="margin-top:0;"><?php esc_html_e( 'Name', 'rangerhq-buddy' ); ?></h2>
|
||||
<h2><?php esc_html_e( 'Name', 'rangerhq-buddy' ); ?></h2>
|
||||
<p>
|
||||
<label for="buddy_name"><?php esc_html_e( 'What is your Buddy called?', 'rangerhq-buddy' ); ?></label><br>
|
||||
<input type="text"
|
||||
|
||||
Reference in New Issue
Block a user